Philippe Canal
Philippe Canal
This looks like a nice feature thanks. I wonder if rather than a single list (that is either an inclusion list or an exclusion list), we should allow both ......
> (as opposed to using @ which cannot work in the current implementation). Why can't it work? Having the @ should end up being equivalent to listing the files explicitly...
> All directories will be copied in allowlist mode, TFileMerger indeeds creates the directory in the output file before it checks whether they have any content. I suspect we could...
Side note: this PR was arbitrarily picked to check the test coverage feature on a PR.
Does the new code 'properly' warning if a branch is actually missing?
> I see sporadic errors of roottest-root-io-evolution-fixarr2 on Mac platforms. What is the error?
> For me ROOTEXE_OPTS is much clear compared to RootExeOptions. > I rather prefer replace use of RootExeOptions - by ROOTEXE_OPTS. I totally agree. Can you make a separate PR...
> Old Makefile-based tests may miss such problem while only stdout was analyzed - which is ok at this moment The old makefile would not (should not) missed any failure...
> I just checked roottest repository - Makefile not activate fixarr target. > So test was not running at all. Fair enough. We should probably open an issue to remind...
Any action/decision of this issue should be reflected in roottest/root/io/alloc.