Philippe Canal
Philippe Canal
> Is there a tolerance parameter that lets us assume codecov will have a few false positives per PR so that it doesn't get a nasty "❌" marker? Hide it...
Explanation of: EXPECT_EQ: [IntersectRegion.test.cc line 2527](https://app.codecov.io/gh/celeritas-project/celeritas/pull/2032?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=celeritas-project#2a6638839990310f9d0c3d6d5907668a-R2527) (from https://github.com/celeritas-project/celeritas/pull/2032) The report is 'technically' sort of correct (albeit not that relevant). We have some use of `EXPEC_EQ` on one line: ``` EXPECT_EQ(SignedSense::inside,...
> We can't afford to go through every PR after codecov has run and add "GCOV" markers to EXPECT_EQ conditions that happen to wrap to two lines. Agreed. > Ideally...
At the moment the rootmap file does not support `enum` (nor C++20 concepts). For enums, the situations can be improved for `enum class` which can be forward declared (but old...
The concern on this patch is that due to the ( `
> Yep, I guess that if you use minor> 2^23 with major = 0, then this patch would solve it. I guess we should warn or error out if `(...
> I believe the current failures are related to the roottest branch not being up-to-date with the latest master Close but not quite. What is happening in the reverse. Once...
> Outstanding asan diagnostics: We should open a issue to record those.
> What about the libgfortran dyld failure on mac? We indeed need to 'fix' that part before merging.
@phsft-bot build