Results 175 comments of Phillip

What's the `except OSError` catching here (`L242`) ? Are you just using it to give a custom error?

Is there a reason to do this rather than initialising a new object?

I think this is a good addition, I imagine it'll be a little easier for `orix` as we don't need a bunch of data modules?

> Considering that you're in favor of docstring testing @pc494, I will set up testing of all docstring examples except the ones where a crystal map or similar files are...

Honestly, I get emails far bigger than 1MB pretty regularly so I wouldn't worry to much about it if it improves user experience.

Might also be worth checking how MTEX treats these objects as a lot of the early implementations follow their patterns...

numpy seem better to me, I've just found "what would MTEX do?" a good way to understand bits of orix I didn't write.

This looks like it would a really really cool addition and it ties in really nicely with the density based clustering workflow. Feel free to tag me if you need...

Naming is hard. Are `Cluster` or `Region` any good?

Something like what I have below as a definition (so that we know what we mean) **Region** : Map points that belong to a "Region" are similar some way -...