Patrick Boettcher

Results 155 comments of Patrick Boettcher

You mean, instead of the thrown exceptions in case of errors? Are there that many errors thrown when setting the root schema?

I see your point, but I'm unsure which kind of finer graded error-messages this would provide by just having a callback called instead of an exception. The schema is so...

What would you think if dedicated exceptions would be thrown for the errors? I'd prefer actually.

I know this is possible in Python, but is this doable in C++? Customizing exceptions arguments? I'd be happy to have a look if you'd have some time to try...

Sounds good. What would be a estimated time of arrival if you could get your hands on it?

LGTM; but please get rid of the white-space changes in the CMakeLists.txt of the test-suite.

No, don't run clang-format on the cmake-lists-file. It's only for C/C++ files. Just revert all your changes of the CMakeLists.txt-file and only commit your actual change.

I'm overloaded, I need to find some time to take a closer look to the open PRs.

This is due to the schema needing a uri-format-validation. Some fields in it are using `"format": "uri"` which is by default not supported by this library. See here: https://github.com/pboettch/json-schema-validator/blob/main/src/string-format-check.cpp What...

Yeah, there is a branch where the subschema-validation-error gets more explicit, but it hasn't been merged, because... I don't remember - lack of time. Please check this branch to see...