json-schema-validator icon indicating copy to clipboard operation
json-schema-validator copied to clipboard

Published 20 hours ago • verified publisher icon pboettch

Add uri format check

Open sebasfalcone opened this issue 2 years ago • 4 comments

This PR aims to close the following issue

Change log

  • Added URI format validation (RFC 3986)
  • Added tests for URI format
  • Removed URI from WILL_FAIL list tests

sebasfalcone avatar Sep 22 '22 18:09 sebasfalcone

LGTM; but please get rid of the white-space changes in the CMakeLists.txt of the test-suite.

pboettch avatar Sep 23 '22 08:09 pboettch

@pboettch I've run the clang-format to the CMakeLists.txt file, let me know if it's okay. Thanks for the help and quick responses!

sebasfalcone avatar Sep 23 '22 11:09 sebasfalcone

No, don't run clang-format on the cmake-lists-file. It's only for C/C++ files.

Just revert all your changes of the CMakeLists.txt-file and only commit your actual change.

pboettch avatar Sep 23 '22 12:09 pboettch

What a mess I've made. Sorry for the waterfall of notification :)

sebasfalcone avatar Sep 23 '22 13:09 sebasfalcone

Hello @pboettch, how's that going? Is this PR on any road-map for the project?

sebasfalcone avatar Sep 30 '22 11:09 sebasfalcone

I'm overloaded, I need to find some time to take a closer look to the open PRs.

pboettch avatar Sep 30 '22 14:09 pboettch