Patrick Boettcher
Patrick Boettcher
Not sure why travis is failing, it works locally.
Happy to hear that. Same here. Used happily in two different production environments. One of it really uses it all, especially the key-feature: multiple RTU-slaves. Regarding `WRITE_SINGLE_REGISTER` and `WRITE_MULTIPLE_REGISTERS` distinction...
Stephane does not want to include CMake support. In my fork, which is not up-to-date I integrated a PR which adds CMake support. https://github.com/pboettch/libmodbus/
Thanks for your PR. Adding 0x14 and 0x15 is a good thing. I have two or three remarks: 1. I think you should consider fixing all your indent and white-space-problems...
@OliverDDS Your manually made coding-style changes weren't enough, I opened a PR on your repo which includes the changes I got after running clang-format like this, feel free to squash...
Patches are welcome. Do you think you could contribute something?
Why not adding debug and analyze code to the library, for example in a tools-dir? We could still debate on a patch once it's there. IMHO.
Please use Github's Pull-request feature for code-reviews. (Clone this repo onto your account, push to it and then "Create Pull Request")
Just mention in your PR that it doesn't work and that you just want a review. People are generally nice here because all useful contribution efforts are seen as a...
That's what I wanted to say with clone to your account. Fork is the right word.