Pierrick Bouvier

It seems Jenkins supports that kind of thing out of the box through `Project-based Matrix Authorization Strategy` that allows to restrict access to jobs per user. See this [example](https://www.tothenew.com/blog/jenkins-implementing-project-based-matrix-authorization-strategy/). This...

To help a bit, we reproduced CI on our side, for [this](https://github.com/nodejs/node/commit/ee91acb49d64f41b2bd7fe9a094fda3557340061) recent commit. [log](https://gitlab.com/Linaro/windowsonarm/nightly/-/jobs/2503920989) | [run script](https://gitlab.com/Linaro/windowsonarm/packages/nodejs-testing/-/blob/master/recipe.sh) (build and test x64 + arm64 variants, and compare test results) As...

Just a thought, but this *might* be related to nodejs build system layer (gyp). V8_EXPORT_PRIVATE is defined [here](https://github.com/nodejs/node/blob/4e97ad7ae1c6d4639f227094f3270de44214c4f1/deps/v8/src/base/macros.h#L390) following other macros: ``` // Setup for Windows shared library export. #ifdef...

@targos I can confirm this compilation error is not present when building v8 directly. I'd suggest a fix around nodejs build system with macros explained above.

I'll try to look at it, but that would be better if someone who worked on gyp/gn layer tackles this. First, I'm working to upstream https://github.com/nodejs/node-v8/issues/240.

@targos: For now, how do you deal with custom patches that nodejs applies to v8? Are there kept somewhere?

You can safely remove that V8_EXPORT_PRIVATE in src/wasm/function-body-decoder-impl.h. Another class inherits from the one defining this `StackEffect` function, and reuse V8_EXPORT_PRIVATE, which is forbidden by msvc (should be defined either...

@targos After trying random stuff around node build system, I could not get something that was solving this issue. I suggest you keep a patch (on node side) removing that...

Those functions were implemented in [this](https://chromium-review.googlesource.com/c/v8/v8/+/3913036) patch (merged upstream). Patch you mention can probably be deleted (with updated v8), as functions are now implemented.

Job windows-arm-simple is now set to run daily, to evaluate stability in time. For now, build for arm64 is already done [here](https://ci.nodejs.org/job/node-compile-windows/nodes=win-vs2019-arm64/), but not testing.