Piotr Balcer
Piotr Balcer
Just to be clear, it's not that we don't want to fix it properly. But it's not that simple, and we *really* tried. PMDK's build system is just very complicated,...
This is either a glibc or valgrind issue. See this message from the attached log: > Your program just tried to execute an instruction that Valgrind > did not recognise....
Is your build system using PMDK's fork of valgrind (https://github.com/pmem/valgrind)? If it does, then it's possible that a new libc version is issuing instructions that the forked valgrind does not...
Even though I came up with it, in hindsight I think that the name `shm` doesn't fully represent what `datapool_shm` does. A more descriptive name would be `anon` for anonymous...
You are right that the variables set by `pkg-config` didn't match the ones the `FindCheck.cmake` script sets - but it's arguable that it's the `pkg-config` that does the wrong thing....
@intel/llvm-gatekeepers this is ready for merge from our side. The HIP failure is unrelated and is affecting all other PRs.
> @igchor, this PR broke our post-commit, could you please take a look? https://github.com/intel/llvm/actions/runs/10106492701 > > ``` > FAILED: _deps/unified-memory-framework-build/src/CMakeFiles/umf.dir/provider/provider_os_memory.c.o > ccache /opt/sycl/bin/clang -DUMF_SHARED_LIBRARY -DUMF_VERSION=0.9.0-rc1.git18.g1c34aae -DUR_ENABLE_SANITIZER -DUR_VALIDATION_LAYER_SUPPORTED_VERSION=\"0\" -DUR_VERSION=\"0\" -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE...
> CI on macOS is also broken: > > ``` > -- Checking for module 'hwloc>=2.3.0' > -- No package 'hwloc' found > -- Checking for module 'libhwloc' using find_library()...
Also, we might want to document this, right now the tracing layer [documentation](https://github.com/oneapi-src/unified-runtime/blob/main/scripts/core/INTRO.rst#tracing) only lists the xpti entry points.
@nrspruit having looked at this code, device -> handle maps for both kernel and programs may have introduced quite a few subtle issues that are hard to detect. This stems...