Piotr Balcer

Results 193 comments of Piotr Balcer

I hate those overcomplicated benchmarks... You are right. But the benchmark app should ideally never crash, no matter how broken the config is. So while adding the nestings for now...

That's a good idea, and should be relatively simple to implement. 👍

We might implement pool shrinking after we implement pmem/pmdk#4187. Right now it's just not realistic. And yes, you should be able to add parts to an existing poolset. How would...

I've been very reluctant to introduce any generic interfaces around space utilization for the reasons you list. Right now there's an API to retrieve the total size of allocated objects,...

Not in the directory, but where the user specified. I think it should look like this: ``` pmempool create [] [] [] Available options: -a, --autogrow [directories ...] Create an...

I think the problem is discoverability of this feature. Most probably skip over the directories section or poolsets man page sections. Maybe we should add a command to create a...

Hmm, I think it would be useful in general to resolve env variables. As for $HOME - I wouldn't expect people to mount pmem inside of the home directory -...

Try enabling debug logs, and it should tell you what's the error. You can also use `pmem_errormsg()`. But, in general, if adding PMEM_FILE_CREATE helps, then that means the file likely...

Enabling debug logs (https://pmem.io/pmdk/manpages/linux/master/libpmem/libpmem.7/) will help you decipher that error. Looking more closely, I think your problem is trying to map 1/4 of a page. `If PMEM_FILE_CREATE is not specified...

This partially solves pmem/issues#553