unified-runtime icon indicating copy to clipboard operation
unified-runtime copied to clipboard

fix leaks on level-zero interop program and kernel handles

Open pbalcer opened this issue 1 year ago • 5 comments

pbalcer avatar May 23 '24 10:05 pbalcer

@nrspruit having looked at this code, device -> handle maps for both kernel and programs may have introduced quite a few subtle issues that are hard to detect. This stems from state duplication. We should probably refactor this code so that the native handles are ideally stored only in one place.

pbalcer avatar May 23 '24 10:05 pbalcer

/e2e-level-zero

pbalcer avatar May 23 '24 11:05 pbalcer

E2E L0 build: https://github.com/oneapi-src/unified-runtime/actions/runs/9207183097

github-actions[bot] avatar May 23 '24 11:05 github-actions[bot]

E2E L0 build: https://github.com/oneapi-src/unified-runtime/actions/runs/9207183097 Job status: failure. Test status: failure

github-actions[bot] avatar May 23 '24 11:05 github-actions[bot]

SYCL E2E failure is unrelated. It's failing on other PRs as well (e.g., https://github.com/intel/llvm/actions/runs/9206096279/job/25325394817?pr=13892).

pbalcer avatar May 23 '24 11:05 pbalcer

@nrspruit having looked at this code, device -> handle maps for both kernel and programs may have introduced quite a few subtle issues that are hard to detect. This stems from state duplication. We should probably refactor this code so that the native handles are ideally stored only in one place.

I started doing some refactor here: https://github.com/oneapi-src/unified-runtime/pull/1607/files

There's also a problem with handling multiple zeKernels that I want to address. It would be good to have a machine where we can test this with multiple devices, tough.

igchor avatar May 23 '24 14:05 igchor

All the test failures are unrelated.

pbalcer avatar May 23 '24 14:05 pbalcer

It would be good to have a machine where we can test this with multiple devices

No promises, but hopefully we can add a runner with multiple devices next week.

pbalcer avatar May 23 '24 14:05 pbalcer

/e2e-level-zero

pbalcer avatar May 24 '24 08:05 pbalcer

E2E L0 build: https://github.com/oneapi-src/unified-runtime/actions/runs/9221320365

github-actions[bot] avatar May 24 '24 08:05 github-actions[bot]

E2E L0 build: https://github.com/oneapi-src/unified-runtime/actions/runs/9221320365 Job status: failure. Test status: skipped

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

/e2e-level-zero

pbalcer avatar May 24 '24 09:05 pbalcer

E2E L0 build: https://github.com/oneapi-src/unified-runtime/actions/runs/9221654634

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]

E2E L0 build: https://github.com/oneapi-src/unified-runtime/actions/runs/9221654634 Job status: success. Test status: success

github-actions[bot] avatar May 24 '24 09:05 github-actions[bot]