Results 54 comments of Pavel Tomin

This trick https://github.com/GEOS-DEV/GEOS/blob/cb20b88c5e2d9afcf0b727bd8abb70f2c5366772/src/coreComponents/physicsSolvers/fluidFlow/CompositionalMultiphaseBase.cpp#L2313 and this https://github.com/GEOS-DEV/GEOS/blob/cb20b88c5e2d9afcf0b727bd8abb70f2c5366772/src/coreComponents/physicsSolvers/fluidFlow/SinglePhaseBase.cpp#L697 can be removed.

> Even frozen porosity change during initialization, some inevitable update of porosity after initialization would still move the model away from equilibrium, as Biot porosity depends on stress and pressure....

`FAILED: 7 python3(ThermoPoroElastic_staircase_co2_smoke_01_2_restartcheck), python3(impermeableFault_smoke_01_2_restartcheck), python3(permeableFault_smoke_01_2_restartcheck), python3(PoroElastic_staircase_singlephase_3d_fim_01_2_restartcheck), python3(PoroElastic_staircase_singlephase_3d_sequential_01_2_restartcheck), python3(PoroElastic_staircase_co2_3d_fim_01_2_restartcheck), python3(PoroElastic_staircase_co2_3d_sequential_01_2_restartcheck)` Since staircase tests use poromechanics initialization, they are expected to have diffs

> In `SolidMechanicsLagrangianFEM::calculateResidualNorm`, `Rdisplacement` is actually computed. I agree to remove `Rtotal`, which is a bit confusing; but suggest to keep both `Rdisplacement` and `Rtraction` for `SolidMechanicsLagrangeContact::calculateContactResidualNorm` to check the...

See also https://github.com/GEOS-DEV/GEOS/issues/2826

Thank you, @IsaacJu-debug. My suggestions: - add a few test cases that you are sure running fine - use them as reference and refactor your code: main thing is to...

@castelletto1 @CusiniM is this good to go ?