Patrick Hulce

Results 308 comments of Patrick Hulce

Thanks for filing @brunojcm? I wasn't aware neutral is an option. How does it appear in the GitHub UI? I'm not sure how to set it or whether it would...

It's still open @ognjenjevremovic thanks for wanting to help! You'll want to take a look at the following block of code where this happens. https://github.com/GoogleChrome/lighthouse-ci/blob/7f46602f1e2d86effcda994ec951664982e3dc8a/packages/cli/src/upload/upload.js#L254-L291 The task here is to...

Hm yeah I can reproduce this too. Seems like there was a difference in the median stat compared to the representative run? That would expectedly produce this result and would...

Thanks for filing @OliverJAsh! I'm hesitant to remove the `--no-merges` *by default*. You are of course correct there are others ways of going about it using the CI configuration, but...

Challenges: we're gonna have 3 differently named and used tokens floating around 😢 At what point do we just give up and add users with ACLs?

Correct @WillsB3, we decided against making it required by default because it's essentially noise for everyone using basic auth already. That means it wasn't a breaking change so split out...

You can delete projects from the dashboard with the admin token already. It's on the administrative settings page of each project. ![image](https://user-images.githubusercontent.com/2301202/83279354-9da39380-a19a-11ea-8170-1a42373c80dc.png) The auth *within* each project I'm pretty happy...

What if instead of yet another token, we add a "create projects passphrase" or something that can be configured in the lighthouserc.js? That way it's opt-in and not quite as...

Not being dense :) It depends how the server is initialized, so you might not be using one. If you're using the node package directly then you're effectively passing in...

SGTM! I was thinking the new project button exists in the project list sidebar (on every route) and the project list route. If you're interested in making this happen, I...