Patrick Hulce

Results 308 comments of Patrick Hulce

> I have a big disabled assertions list and looks like I need to duplicate it for each separate url pattern Could you use a `lighthouserc.js` instead of JSON and...

hey @felixck12 thanks for filing! Smoother mobile and desktop simultaneous support is on our radar since right now it's a bit complicated to get them to live together. To get...

Yes still on the radar @kmcrawford. This issue wouldn't unlock any new functionality you can't accomplish today though so it's definitely not high on the list. If you'd like it...

Thanks very much @dkarzon! I think the complexity here though is in how to design the dashboard to avoid the odd numbered graph issues while still visualizing on smaller desktop...

> @patrickhulce what do you mean by odd numbered graph issues here? Simply that we've got a nice two column layout going at the moment that fits nicely in a...

if we flip the FCP/LCP graph above the other two then LGTM :)

Which unit tests? Link to log output would be great

I understand that, but I can't help unless I know _which_ tests and _how_ they are being broken :)

OK and have you opened the diff to see if what has changed is expected? If you're changing the UI, updating snapshots is normal :)

Thanks for filing @synergychen! This is expected behavior. `.lighthouseci` is not the output dir, but a temporary working directory used regardless of whether `upload` is ever invoked. At the moment...