Patrick Dillon

Results 69 comments of Patrick Dillon

> /lgtm /approve oh thanks! I pushed a commit before checking github and stomped on this. I would have created a bug and merged it had I noticed. I should...

> Yes, this might work. I'm just wondering overall why the DNS check was introduced and what would happen if we remove it completely, i.e. go on even before DNS...

So if we're trying to install to a subnet in the associated cidr block set (e.g. `10.190.0.0/16`), CAPA will create security groups with the (primary) cidr block `10.0.0.0/16`.

#1909 fixed the tests, which are now failing with: ``` INSUFFICIENT CI testing for "ClusterAPIInstallGCP". F0715 17:49:34.051041 169158 root.go:64] Error running codegen: error: "install should succeed: infrastructure" only passed 71%,...

Just reran verify and it looks like our bug fixes are paying off and we're trending in the right direction (86%, up from 71%): ``` F0729 19:20:08.510204 169977 root.go:64] Error...

I ran ~20 GCP techpreview jobs yesterday using gangway. Looking at the infrastructure test links that @stbenjam posted above, I believe we are now seeing a success rate ~98%: [GCP...