Patrick Dillon

Results 69 comments of Patrick Dillon

/hold cancel @JoelSpeed finally ready, thanks!

@JoelSpeed these fields are supposed to be immutable. Should i just add validation to enforce that?

/hold cancel @JoelSpeed I just noticed this never merged due to essentially a rebase conflict. I rebased and reran `make update`. PTAL

Sorry @nojnhuh I missed your comment the first time around, and only noticed it now that I have opened a PR for the implementation. [This commit](https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5532/commits/90c2c2d832867ca422adcb15d44713091e600eba) from my PR provides...

/remove-lifecycle rotten Sorry sorry I will update this asap

I'm primarily using this to build a release image to help with debugging.