Pat
Pat
I'm going to delegate to @stevehipwell for his expertise here plus I know he has some much improved CI he wants to push :)
No packages exist yet so they are not public, assuming we are pushing to `ghcr.io/${{ github.repository }}` which would map to `ghcr.io/fluent/helm-charts`. We can change the package visibility easily enough,...
It looks ok now but I know @stevehipwell was working on a few things
> @patrick-stephens You've approved this PR. Can you also merge it? > Can you also have a look at my other PRs? > https://github.com/fluent/fluent-bit/pulls/ThomasDevoogdt It requires approval from the code...
> @patrick-stephens @edsiper It's again radio silence for a week... BTW, I have a bunch of other PRs without any review either. I'm afraid it is quite busy at the...
@ThomasDevoogdt will have a look once I'm back from PTO
@edsiper this looks ok to me
Can we rebase to see if it resolves the unit test failures?
@edsiper will be merging when he is happy to put it in a release - be aware we're finalising the 4.0 release now.
Looks fine to me, just want to check @edsiper is happy with the commit title