Pat

Results 480 comments of Pat

@pkubaj please also follow the contribution guidelines, specifically around naming of PR and commit messages: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes

Can you link the docs PR?

Can we add any integration tests? https://github.com/fluent/fluent-bit-ci

Note we will need a docs PR I think to update the existing caveat (I think I added it actually when I found this issue previously): https://docs.fluentbit.io/manual/pipeline/parsers/regular-expression > A common...

This is such a time sink when you forget the hidden rules so be good to merge!

@fweimer-rh thanks for this, could you just make sure your commits are signed off? See the failed check for details and how to fix: https://github.com/fluent/fluent-bit/pull/6704/checks?check_run_id=10723974841 From https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md: ``` When running...

We need to confirm this compiles for all targets (per the PR template) so I've triggered that test but really that can be done locally beforehand too.

> > We need to confirm this compiles for all targets (per the PR template) so I've triggered that test but really that can be done locally beforehand too. >...

@bryanwsmith what needs changing on this PR and can you push it?

We're going to need a lot more details on how you built and how you're running.