fluent-bit
fluent-bit copied to clipboard
build: use the system provided libmsgpack and libsqlite3 if found
This is a follow-up on https://github.com/fluent/fluent-bit/pull/8930.
Enter [N/A] in the box, if an item is not applicable to your change.
Testing Before we can approve your change; please submit the following in a comment:
- [N/A] Example configuration file for the change
- [N/A] Debug log output from testing the change
- [N/A] Attached Valgrind output that shows no leaks or memory corruption was found
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
- [N/A] Run local packaging test showing all targets (including any new ones) build.
- [N/A] Set
ok-package-testlabel to test for all targets (requires maintainer to do).
Documentation
- [N/A] Documentation required for this feature
Backporting
- [N/A] Backport to latest stable release.
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
@edsiper It has been a while. Any chance that this gets approved? I try to reduce my own patch list.
We're using these patches also for the Yocto recipe, so I’m in support of this change.
Thank you for all the unbundling work @ThomasDevoogdt!
Thank you for all the unbundling work @ThomasDevoogdt!
Thx!
We're using these patches also for the Yocto recipe, so I’m in support of this change.
Then you might also need https://github.com/fluent/fluent-bit/pull/9600, which I found out later when bringing it all to buildroot.
@patrick-stephens Can you also have a look at https://github.com/fluent/fluent-bit/pull/9600, which relates.
@patrick-stephens You've approved this PR. Can you also merge it? Can you also have a look at my other PRs? https://github.com/fluent/fluent-bit/pulls/ThomasDevoogdt
@patrick-stephens You've approved this PR. Can you also merge it? Can you also have a look at my other PRs? https://github.com/fluent/fluent-bit/pulls/ThomasDevoogdt
It requires approval from the code owners in areas that I'm not so I'll ping @edsiper
@patrick-stephens @edsiper It's again radio silence for a week... BTW, I have a bunch of other PRs without any review either.
@patrick-stephens @edsiper It's again radio silence for a week... BTW, I have a bunch of other PRs without any review either.
I'm afraid it is quite busy at the moment so it will be in the review queue and I'll flag it internally but also feel free to highlight in the community meeting too for visibility.
@patrick-stephens @edsiper Is there in the meantime some bandwidth to look further at this PR. And preferably also to my other PRs? Would be much appreciated!
@patrick-stephens ping
@patrick-stephens @edsiper I see that 4.0.0 has landed, this is the ideal moment to consider this PR.
@ThomasDevoogdt will have a look once I'm back from PTO
@edsiper this looks ok to me
@patrick-stephens @cosmo0920 Thanks for the review and merging this PR!
@cosmo0920 @patrick-stephens on merging PRs, please verify carefully the commits subjects, prefixes are important for maintenance:
the c-ares and nghttp2 commits are for cmake/ directory , initially I thought it was wrong subject for dependencies.
what was expected was:
- cmake: c-ares: ...
- cmake: nghttp2: ...
@cosmo0920 @patrick-stephens on merging PRs, please verify carefully the commits subjects, prefixes are important for maintenance:
the
c-aresandnghttp2commits are for cmake/ directory , initially I thought it was wrong subject for dependencies.what was expected was:
- cmake: c-ares: ...
- cmake: nghttp2: ...
@edsiper Hi, I will also try to have a better subject in the future. Thanks.