fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

build: use the system provided libmsgpack and libsqlite3 if found

Open ThomasDevoogdt opened this issue 1 year ago • 1 comments

This is a follow-up on https://github.com/fluent/fluent-bit/pull/8930.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

ThomasDevoogdt avatar Nov 09 '24 19:11 ThomasDevoogdt

@edsiper It has been a while. Any chance that this gets approved? I try to reduce my own patch list.

ThomasDevoogdt avatar Dec 15 '24 14:12 ThomasDevoogdt

We're using these patches also for the Yocto recipe, so I’m in support of this change.

Thank you for all the unbundling work @ThomasDevoogdt!

Arctize avatar Jan 09 '25 15:01 Arctize

Thank you for all the unbundling work @ThomasDevoogdt!

Thx!

We're using these patches also for the Yocto recipe, so I’m in support of this change.

Then you might also need https://github.com/fluent/fluent-bit/pull/9600, which I found out later when bringing it all to buildroot.

ThomasDevoogdt avatar Jan 09 '25 15:01 ThomasDevoogdt

@patrick-stephens Can you also have a look at https://github.com/fluent/fluent-bit/pull/9600, which relates.

ThomasDevoogdt avatar Jan 10 '25 16:01 ThomasDevoogdt

@patrick-stephens You've approved this PR. Can you also merge it? Can you also have a look at my other PRs? https://github.com/fluent/fluent-bit/pulls/ThomasDevoogdt

ThomasDevoogdt avatar Jan 15 '25 15:01 ThomasDevoogdt

@patrick-stephens You've approved this PR. Can you also merge it? Can you also have a look at my other PRs? https://github.com/fluent/fluent-bit/pulls/ThomasDevoogdt

It requires approval from the code owners in areas that I'm not so I'll ping @edsiper

patrick-stephens avatar Jan 15 '25 15:01 patrick-stephens

@patrick-stephens @edsiper It's again radio silence for a week... BTW, I have a bunch of other PRs without any review either.

ThomasDevoogdt avatar Jan 21 '25 20:01 ThomasDevoogdt

@patrick-stephens @edsiper It's again radio silence for a week... BTW, I have a bunch of other PRs without any review either.

I'm afraid it is quite busy at the moment so it will be in the review queue and I'll flag it internally but also feel free to highlight in the community meeting too for visibility.

patrick-stephens avatar Jan 22 '25 15:01 patrick-stephens

@patrick-stephens @edsiper Is there in the meantime some bandwidth to look further at this PR. And preferably also to my other PRs? Would be much appreciated!

ThomasDevoogdt avatar Feb 18 '25 22:02 ThomasDevoogdt

@patrick-stephens ping

ThomasDevoogdt avatar Mar 24 '25 21:03 ThomasDevoogdt

@patrick-stephens @edsiper I see that 4.0.0 has landed, this is the ideal moment to consider this PR.

ThomasDevoogdt avatar Apr 01 '25 20:04 ThomasDevoogdt

@ThomasDevoogdt will have a look once I'm back from PTO

patrick-stephens avatar Apr 23 '25 09:04 patrick-stephens

@edsiper this looks ok to me

patrick-stephens avatar Apr 29 '25 11:04 patrick-stephens

@patrick-stephens @cosmo0920 Thanks for the review and merging this PR!

ThomasDevoogdt avatar Apr 30 '25 10:04 ThomasDevoogdt

@cosmo0920 @patrick-stephens on merging PRs, please verify carefully the commits subjects, prefixes are important for maintenance:

image

the c-ares and nghttp2 commits are for cmake/ directory , initially I thought it was wrong subject for dependencies.

what was expected was:

  • cmake: c-ares: ...
  • cmake: nghttp2: ...

edsiper avatar Apr 30 '25 20:04 edsiper

@cosmo0920 @patrick-stephens on merging PRs, please verify carefully the commits subjects, prefixes are important for maintenance:

image

the c-ares and nghttp2 commits are for cmake/ directory , initially I thought it was wrong subject for dependencies.

what was expected was:

  • cmake: c-ares: ...
  • cmake: nghttp2: ...

@edsiper Hi, I will also try to have a better subject in the future. Thanks.

ThomasDevoogdt avatar Apr 30 '25 21:04 ThomasDevoogdt