Pat

Results 470 comments of Pat

> We already have a macOS workflow which has unit-testing: https://github.com/fluent/fluent-bit/blob/master/.github/workflows/unit-tests.yaml#L80 Is there any lack of mechanism to detect failing of macOS builds in this workflow? https://github.com/fluent/fluent-bit/blob/master/.github/workflows/unit-tests.yaml The only thing...

Can you provide some context in the description please? @leonardo-albertovich do we want a general section on threaded support somewhere?

Please add some description plus any PR links for it, e.g. is this already implemented or waiting on a PR?

That is not static linking there, your example is explicitly doing shared linking and also doing it with libc enabled. You need disable CGO at least.

Thanks for the contribution but please resolve the DCO requirements - we cannot merge without it unfortunately.

Any chance we can add some basic sanity tests for the container build to confirm?

> Hi @patrick-stephens, > > > some basic sanity tests for the container build to confirm? > > Isn't [.github/workflows/pr-image-tests.yaml:116-119](https://github.com/fluent/fluent-bit/blob/master/.github/workflows/pr-image-tests.yaml#L116-L119) (https://github.com/fluent/fluent-bit/actions/runs/14580963650/job/40897379281?pr=10233) sufficient for this pull request? > > Thank you....

> @edsiper and @patrick-stephens, > > Do you have any thoughts / requirements / doubts on this pull request? Considering this pull request was part of original https://github.com/fluent/fluent-bit/pull/10180 which was...

I've approved it, will be merged at some point

@cosmo0920 are you ok with this so we can merge @edsiper ?