fluent-bit icon indicating copy to clipboard operation
fluent-bit copied to clipboard

Published 20 hours ago • verified publisher icon fluent

wasm: detect non-amd64 and non-i386 architectures

Open pkubaj opened this issue 2 years ago • 4 comments

Currently all the architectures that don't match the above detected are misdetected as amd64 or i386, depending on the bitness.

Enter [N/A] in the box, if an item is not applicable to your change.

Testing Before we can approve your change; please submit the following in a comment:

  • [N/A] Example configuration file for the change
  • [N/A] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • [N/A] Run local packaging test showing all targets (including any new ones) build.
  • [N/A] Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • [N/A] Documentation required for this feature

Backporting

  • [N/A] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

pkubaj avatar Mar 08 '23 22:03 pkubaj

@cosmo0920 should we be making these changes in the upstream project then consuming them here?

patrick-stephens avatar Mar 10 '23 12:03 patrick-stephens

@pkubaj please also follow the contribution guidelines, specifically around naming of PR and commit messages: https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#commit-changes

patrick-stephens avatar Mar 10 '23 12:03 patrick-stephens

@cosmo0920 should we be making these changes in the upstream project then consuming them here?

Yes. We should handle similar changes in upstream not here.

cosmo0920 avatar Mar 22 '23 07:03 cosmo0920

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Jun 21 '23 02:06 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Nov 27 '24 02:11 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 28 '25 02:08 github-actions[bot]