Patrick Miller

Results 31 comments of Patrick Miller

@maximbaz regarding `#4` from [your last comment block](https://github.com/browserpass/browserpass-extension/pull/290#issuecomment-1146703020), I don't completely disagree; but I think there is a problem with the part about putting the `Delete` action / icon in...

Hey @maximbaz, just responding to your overview. > 1. Add credentials -> focus "Secret" -> type "ab" -> press Backspace twice ==> it cannot remove "a", one char incorrectly remains...

> Let's not do any configurable caching - my idea is much simpler than that slightly_smiling_face When I click `>` button to see details of the password entry, the data...

> I have indeed configured touch requirement for every decryption operation. OK I probably need to look at the code before giving any further comments, so far I was commenting...

> It was counter-intuitive for me to see "Secret" and "Login" fields above textarea when I pressed >, but after clicking "Edit" the "Login" disappears, and only "Secret" field remains...

@maximbaz @erayd I have made `a lot` of changes / improvements to the extension and addressed most of your feedback, but not all yet. Please reference [my current todo's ](https://github.com/browserpass/browserpass-extension/issues/61#issuecomment-1166778554)...

@erayd @maximbaz I've also replaced the deprecated `confirm` with a `` element / component as requested. ![Screenshot_2022-07-26_21-38-59](https://user-images.githubusercontent.com/3914379/181155948-1c1e560f-6e56-4956-b88f-b40d032abbc4.png) ![Screenshot_2022-07-26_21-38-03](https://user-images.githubusercontent.com/3914379/181155949-76e016eb-23b7-4b63-8bca-590bcfa692bb.png)

@maximbaz @erayd be advised I've set the host capabilities version in my branches. browserpass-extension (this pr) ```js # src/background.js settings.version = response.version; const EDIT_VERSION = 3 * 1000000 + 1...

@maximbaz @erayd While reviewing part of the native host application I realized the `tree` request was intended to list directories for a password store. I've thrown together a working rough...