Lay Patel comments

Results 13 comments of


                                            Lay Patel

This CI-staging should not be failing based on my changes. ![image](https://github.com/user-attachments/assets/04cad113-8909-4a64-88ed-c4b876a502c6) Seems like dataset-integration failure is common among PRs.

Typo in main Slips screen

Hey @eldraco, @AlyaGomaa looks like it is not printing "Total A". Also it is printed in code. I was able to point it to common/observer.py notify_observers() function, but couldn't move...

Typo in main Slips screen

When I tried to address this issue, I realized that text is already present. The self.print() function is omitting the first few characters. I tried to trace it back to...

Add the filename when reporting "Malicious downloaded file"

Hey @AlyaGomaa I can work on this. I see that we compare hash to determine if a file is malicious. We get hash from files.log. I am not sure how...

Add the filename when reporting "Malicious downloaded file"

Hey @AlyaGomaa, any updates on my previous message?

Add the filename when reporting "Malicious downloaded file"

Hey @AlyaGomaa, I looked into the issue. I am bit confused. Is this that there is file_handler.handle_files() function that add newly downloaded file to database, and checks through "check_malicous_ssl". I...

Add the filename when reporting "Malicious downloaded file"

Hey @AlyaGomaa, I understand that this function will be triggered by files.log file. On seeing I got that I need to add file_name as a part of file_info in file_handler.py...

Add the filename when reporting "Malicious downloaded file"

Hey @AlyaGomaa, can you comment on this so we can close this one.

Read quic.log zeek file, detections done on the server_name for http and tls should be detected in the server_name in quic

Hey @AlyaGomaa is this a new detection module? Also where can I find quic.log zeek file?

Lay Patel

Fix typo and tell_pbar

Fix typo and tell_pbar

Typo in main Slips screen

Typo in main Slips screen

Add the filename when reporting "Malicious downloaded file"

Add the filename when reporting "Malicious downloaded file"

Add the filename when reporting "Malicious downloaded file"

Add the filename when reporting "Malicious downloaded file"

Add the filename when reporting "Malicious downloaded file"

Read quic.log zeek file, detections done on the server_name for http and tls should be detected in the server_name in quic