StratosphereLinuxIPS icon indicating copy to clipboard operation
StratosphereLinuxIPS copied to clipboard

Fix typo and tell_pbar

Open patel-lay opened this issue 1 year ago • 3 comments

#871 #879

Changes proposed

Check if msg is empty or not before calling pbar_sender_pipe()

Typo in main screen "[Main] " overwrote the first few character("Total A"). Adding [Main] is a simple fix but not permenant. I believe more analysis is required to understanding the reason of overwriting. Also the whole statement is printed once after "Flow Processed" line, but then disappears. Careful observation is required to notice this.

Check List (Check all the applicable boxes)

  • [ X] My code follows the code style of this project.
  • [ ] My change requires changes to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [X ] All new and existing tests passed.
  • [ X] This PR does not contain plagiarized content.
  • [ X] The title of my pull request is a short description of the requested changes.

Screenshots

image

image

Note to reviewers

Included in change proposed.

patel-lay avatar Aug 21 '24 23:08 patel-lay

@AlyaGomaa can you review my PR.

patel-lay avatar Aug 28 '24 02:08 patel-lay

This CI-staging should not be failing based on my changes. image

Seems like dataset-integration failure is common among PRs.

patel-lay avatar Aug 28 '24 22:08 patel-lay

@patel-lay yes true, not sure why though, will fix this and re-run CI in your PR and if all goes will i'll merge it

AlyaGomaa avatar Aug 30 '24 20:08 AlyaGomaa

Hey @patel-lay we dropped support for the PBar. thanks for your effort though!

AlyaGomaa avatar Jan 03 '25 12:01 AlyaGomaa