Patrick Connolly

Results 485 comments of Patrick Connolly

Oh, and from this, I hope we can start localizing strings for `client-admin` and `client-report` as well. A system like this will make it easier to manage updates with just...

The [`.github/workflows/push-translations.yml`](https://github.com/patcon/polisServer/blob/320-continuous-localization/.github/workflows/push-translations.yml) workflow seems to be working well. - I added a string with a `demo` key to `en.js`: https://github.com/patcon/polisServer/commit/70ae8c7d0f0b569bf2700f33fe93e22fabb2815a - This kicked off a `mojito push` event: https://github.com/patcon/polisServer/runs/782790438?check_suite_focus=true#step:3:797 -...

Yay! It's working! https://github.com/patcon/polisServer/pull/16 🎉 ## Candidate To Dos - [x] rename `polis` translation repo to `polis-client-participation` - [x] change the default username/password and make them secret - [ ]...

Related Gitter convo (compensation, minnesota, indigenous localization): https://gitter.im/pol-is/polisDeployment?at=5eec0d49c223cc536a2141fa

Ah shoot, that's unexpected to me...! Might you be able to confirm that social media login features work fine when not embedded? --- As an aside, if something did break...

A contributor has recently added Facebook Login support to this Cypress plugin that supports third-party login support: https://github.com/lirantal/cypress-social-logins (normally, cypress is not designed to work within urls outside the site...

As noted in https://github.com/compdemocracy/polis/issues/1549#issue-1408752578, it's perhaps good to also test facebook login (and social login generally) both within iframes (embedded) and directly on the site. It seems that social login...

Heh yep, super-helpful until it takes down the testing infra :) but yay, so now the email test that's been red for a stretch is green! though the _actually_ flaky...

Thanks for the bug report! Seems it's related to this line, which I think @micahstubbs flagged as a bug (via comment) when he was doing the big typescript conversion: https://github.com/compdemocracy/polis/blob/f526a149437e032e0bca5acb6e75c3a6017e84fe/server/src/server.ts#L13198-L13207...

Nice! > although the words agree and disagree are not entirely easy to translate In case helpful, @colinmegill discussed the complexity of translating "pass", in case that helps you (it's...