Patrick Connolly

Results 480 comments of Patrick Connolly
trafficstars

Just wanted to chime in to say that I agree with @assaf's original sentiment that locking to specific node version should be encouraged -- lack of version constraint is a...

:+1: @ljharb I somehow missed that. Still feel `package.json` or `npm-shrinkwrap.json` (latter would need a core issue) would be suitable, but that's otherwise very helpful. Thanks!

Does it? Isn't it just polling an endpoint? Or am I misunderstanding? JSON: https://nodebin.herokai.com/v1/node/linux-x64/latest?range=8.x [https://nodebin.herokai.com/v1/node/linux-x64/latest?range=8.x https://nodebin.herokai.com/v1/node/linux-x64/latest?range=^8.2 https://nodebin.herokai.com/v1/node/linux-x64/latest?range=~8.2 Or txt: https://nodebin.herokai.com/v1/node/linux-x64/latest.txt?range=8.x

I am confused, but that's ok -- this is a long thread. I'm assuming your response is short-hand for saying that a half-way-there UX improvement (that piggybacks on Heroku's semver-resolution...

ah ok, gotcha! What about compressing a longer optional description into base64? Yes, less terse urls for those who use them, but it the flags are optional...? :) I mean,...

Got this working in Docker thanks to @maerics @chapmanjacobd @MDrooker, thanks all! See #96 (I'm 100% sure it can be improved after [or before?] merge 🎉 ) EDIT: just confirmed...

@monurcevik try this version of ffmpeg built with the flags in the upstream docker container (it's managed by core ffmpeg team): https://github.com/mifi/editly/blob/0bfed321e0c659e9c5ce1db1fd1cb8becf5e71d6/Dockerfile#L1

I'm not sure "mandatory" is the right word, but it was mandatory for me :) You might get better feedback by opening a new ticket, as Heroku support is perhaps...

ffmpeg is probably one of the more important version numbers to share :)

In case dockerfiles aren't easy for ppl to read, this is the summary: - ubuntu 18.04 - ffmpeg 4.3.1 (supplied by [this upstream dockefile](https://github.com/jrottenberg/ffmpeg/blob/master/docker-images/4.3/ubuntu1804/Dockerfile) used in compilation, mostly bash RUN...