Patrick Connolly

Results 485 comments of Patrick Connolly

The code rn is working as an MVP, if anyone wants to test. Work that could also be done in this PR, if we wanted: - is this SERVER_DATA approach...

this `__SERVER_DATA__` thing is seemingly a common pattern for react fwiw: - https://www.algolia.com/doc/guides/building-search-ui/going-further/api-keys-security/react/#inline-the-api-key - https://create-react-app.dev/docs/title-and-meta-tags/#injecting-data-from-the-server-into-the-page If we're concerned with being able to serve built clients without proxying them through server...

Perhaps out-of-scope here, but just learned a good way to test login flows easily via test users: - [Facebook: Test Users](https://developers.facebook.com/docs/apps/test-users#appdashboardmanage) - [Facebook: Testing Your Login Flow](https://developers.facebook.com/docs/facebook-login/testing-your-login-flow) @colinmegill worth our...

> My concern here is the introduction of fake SSL in the mainline docker-compose.yml. Yeah, could use some thought. Thinking we could just not add an explicit `depends_on`, and then...

Seems I can note in Facebook app setup instructions to disable "enforce HTTPS": https://developers.facebook.com/blog/post/2018/06/08/enforce-https-facebook-login/ This makes the need for SSL in development a moot point, and allows us to kick...

Just found out that SSL is mandatory for FB login now, so we need to add some self-signed cert for testing (I can perhaps do it in cypress tests workflow):...

Removed omgwtfssl container, and instead using certs from #540

Going to pull Facebook docs into https://github.com/pol-is/polis/issues/541, and deal with this as just a tiny thing later. Moving to draft as its own of review for now

Hey @SebastianRuan, saw that the failing e2e tests were getting in your way here, but I've hopefully got them fixed in https://github.com/compdemocracy/polis/pull/1510 If that gets merged first, you can probably...