Patrick Connolly

Results 485 comments of Patrick Connolly

> Is this the right thing to do next? Definitely. Happy to poke around before, but getting tests passing is usually a good first step before seeking review/feedback. It's possible...

> Is there a quota that we have passed? Ah yeah, I hate it, but that's something that arrived due to GitHub abuse (it's platform-wide): https://github.blog/2021-04-22-github-actions-update-helping-maintainers-combat-bad-actors/ I usually just create...

> would it need to be written `polisConfig.FB_APP_ID()` (with brackets)? Should be able to exec the config.get() commands in polis.config.js and export an object with a bunch of const keys...

I'm glad you disabled some stuff to advance with the work you care about. For correction before the eventual merge, I can explain why it was there and the purpose....

That's awesome! > I had to downgrade node and npm to 14.18.3 and 6.14.15, respectively. Is that a known issue ? I actually didn't know about this constraint for running...

👍 Very in favour of (3)! Def eager for (1) and (2), though (1) is perhaps a bit of a task. (1) and (2) also require a strategy of having...

Nice! Thanks @pluby! There's def a need for something here :) Will review

To clarify, is this change working for you right now? If so, in what sort of environment? (docker?) I'm uncertain if `process.env` can be used without changes elsewhere, as we're...

Ah hey, realizing that client-admin has fresher code, which generalized this urlPrefix logic better, and used it the same way for ajax calls: https://github.com/compdemocracy/polis/blob/f33d0b0471fe2d31d08321b58c74b5e59bb4fe77/client-admin/src/util/net.js#L20 https://github.com/compdemocracy/polis/blob/dev/client-admin/src/util/url.js So you'll just need to:...

Awesome! Much appreciate, @pluby. Looks great Oh, but still needs the domainWhitelist copied over from client-admin `polis.config.template.js`. If you could do that, I'll test it out and give it a...