patak

/ecosystem-ci run

> I wonder if it would be a good idea to add `channels` property to `server.hot` config instead? > > ```ts > import ssrChannel from './ssrChannel' > const server =...

Thanks for the PR @NozomuIkuta! I'll add this one to the team board for discussion. If we merge it, we will be doing it as part of the next minor...

@NozomuIkuta I think you should commit your proposed change at https://github.com/vitejs/vite/pull/15326/files#r1434206818 👍🏼

Thanks for the PR! I mentioned we had this problem here https://github.com/vitejs/vite/pull/15246#pullrequestreview-1767673646. I think it is a good idea to do this, but I don't know if we should merge...

I agree that correctness is more important than performance here. I still think we should merge this one as part of the next minor. We discussed with the team and...

I think the encoding may need to be moved here instead https://github.com/pzerelles/vite/blob/f45775c9515cf9a3d3c9ffc448b871dfc78efe84/packages/vite/src/node/plugins/importAnalysis.ts#L602C17-L602C17

To set expectations, we may start work in 5.1 beta in January. My take is that we should merge it then. I'll be off for a few weeks, then do...

@pzerelles we discussed about this in today's team meeting and decided to move forward with the change, but using a helper for performance reasons that will only transform `%` into...

@pzerelles would you create a minimal repro for the issue you describe with image-tools?