patak

Results 228 comments of patak

Do you plan to send a PR so we can discuss seeing the needed changes?

Discussed with Dominikg, and he suggest to wait a bit before merging this one.

Checking [the reproduction](https://github.com/m1san/vite-issue-repro/blob/530ace562c1c42fef1a86081c39eefe88187f5c4/apps/app-ssr/server.js#L54), `transformIndexHtml` shouldn't be called on the result of `render` as documented in https://vitejs.dev/guide/ssr.html#setting-up-the-dev-server. It is intended to be called for the index.html template.

Let's close this PR. We can keep https://github.com/vitejs/vite/issues/15214 open to discuss. In case it is helpful, there are efforts to integrate RSC and Vite that don't seem to be running...

I think the idea behind the quotes was [originally](https://github.com/vitejs/vite/commit/e6f7fbad75c1b406b9a95060c5d2a42d3a8994a8) to keep the code as a valid module. Maybe we should use `import.meta.__VITE_PRELOAD__`?

It may break if there is a plugin that is checking that all variables are properly defined. I don't know if we are respecting this in all our replacements though,...

@ArnaudBarre do you think that there is something Vite could do to help here? If not, I think we could close this PR in favor of Tailwind reviewing if they...

The CI issue is probably a flaky test, sorry about that. Thanks for the PR, do you have metrics about the perf improvement of this change? I think it may...

Let's close this for now then. Thanks again @Cadienvan, and it isn't worthless. It is just that we need to keep complexity in check so we should only increase it...