Félix Saparelli comments

Results 581 comments of


                                            Félix Saparelli

Is this project dead. Add collaborators ?

@marshallbu If you can clean it up and PR it in mtwitter I'll be happy to pull it. It looks significant so I don't want to touch it myself carelessly...

Is this project dead. Add collaborators ?

Oh, hey didn't see that. Would be good to give npm maintainer access to people too, @AvianFlu. I guess I'll close my fork now :)

Possible soundness issue in ChildImp::wait

This is the same root issue as the other one you just opened, yeah?

"blocking waitpid returned pid=0" from `AsyncGroupChild::wait`

Sure, to conform to the Tokio API this future should be fused. Under unix you're not really supposed to do that (call wait twice) though. (Also love your "people i'm...

"blocking waitpid returned pid=0" from `AsyncGroupChild::wait`

I'd be happy with a PR that made this cancel-safe, for the record. Had a look earlier but it wasn't obvious.

"blocking waitpid returned pid=0" from `AsyncGroupChild::wait`

Right, I had a look at this again and I don't think the issue is really cancel safety. What happens is that when you call `wait` (or `waitpid`), that tells...

Possible soundness issue in JobPort::Drop

Huh, yeah, that does look likely. Unfortunately very busy elsewhere currently but if you want to submit a PR to clear that I'll merge and release asap.

AWS Native running slower than AWS Classic

Creating and deleting lambdas is really slow in native. Anecdotally it takes

Multipassword or multicrypt?

It's an adjustable "cost" that most modern password hashing schemes have. Usually translates to the number of rounds. You adjust it based on current or projected attack power, and based...

Multipassword or multicrypt?

I've edited the example I give to be correct as per your comments.