command-group icon indicating copy to clipboard operation
command-group copied to clipboard

Possible soundness issue in ChildImp::wait

Open gigaroby opened this issue 2 years ago • 1 comments

While conducting an internal unsafe review, we identified a possible soundness issue in ChildImp::wait

https://github.com/watchexec/command-group/blob/b88296fed10b18aebb7ad5889dab5e43b621297f/src/tokio/child/windows.rs#L100-L104

This function and the one below call the Clone impl that appears to undermine the unsafe Drop impl on self.handles.

gigaroby avatar Sep 07 '23 12:09 gigaroby

This is the same root issue as the other one you just opened, yeah?

passcod avatar Sep 07 '23 21:09 passcod