Martin Hoffmann

Results 205 comments of Martin Hoffmann

Thank you for the PR! I am wondering if the type bitmap can ever be empty? Given that both RRSIG and NSEC(3) seem to be included in it, there should...

Ah, right. I suppose the PR can be merge, then.

I’m not sure if considering non-fatal errors with TCP is necessary. Both `write_all` and `read_exact` will already cover `ErrorKind::Interrupted`. `ErrorKind::TimedOut` should probably treated as fatal – it means the socket...

I like the approach in principle, but I do agree that that the trait bounds can seem a little unwieldy. One thing that I learned from using Hyper – which...

Basically, the server itself (i.e., the raw transports) don’t care about the error at all. What exactly should happen if they get one is up for discussion. Hyper just closes...

> But, @AlexanderBand I realise now (looking at the code) that there is a bug. The router certificate file is named after its public key identifier, so this would result...

The built-in server can listen on multiple addresses, so maybe this is of value, anyway?

Thank you for the report and apologies for the embarrassingly late response. Unfortunately, these line numbers are generated in an underlying library and not easily fixable. I switched to a...

Thank you for the report and apologies for the long silence. Are your routers receiving their updates or are they lagging behind?

Quick question: Are you perchance using the json unit reading from files? If so, #93 should provide a fix.