domain icon indicating copy to clipboard operation
domain copied to clipboard

Minor fix for 0.10.0

Open xofyarg opened this issue 9 months ago • 4 comments

Hi, I included two trivial changes when working on an upgrade from domain-0.7 to 0.10. Please let me know if I missed anything. Thanks.

xofyarg avatar May 02 '24 19:05 xofyarg

Thank you for the PR!

I am wondering if the type bitmap can ever be empty? Given that both RRSIG and NSEC(3) seem to be included in it, there should at least be the NSEC(3) record set?

partim avatar May 03 '24 09:05 partim

The NSEC3 bitmap has all of the records present at the owner name, which is empty for an empty non-terminal.

Philip-NLnetLabs avatar May 03 '24 10:05 Philip-NLnetLabs

Ah, right. I suppose the PR can be merge, then.

partim avatar May 03 '24 10:05 partim

I had the same question, and my colleague pointed me at this one:

... the NSEC3 RR exists because it corresponds to an empty non-terminal, in which case the NSEC3 RR will have an empty Type Bit Maps field

https://datatracker.ietf.org/doc/html/rfc5155#section-8.5

xofyarg avatar May 03 '24 14:05 xofyarg