Terence Parr comments

Results 554 comments of


                                            Terence Parr

Categorical features support for tf-df

can't find the PR?

Show leaf values, i.e. leaf weights, for classification trees

yeah, let's see what @tlapusan thanks about creating a special function for classifiers, depending on the decision tree library, that returns a value to display.

Show leaf values, i.e. leaf weights, for classification trees

Rather than a user having a specify a dictionary, I think it's better if we come up with a function that is generic across libraries that returns a value that...

Explain leaf prediction path

I guess that makes sense to me except I'm not sure how we know what the node id is. Do we have a way to display that?

Explain leaf prediction path

cool! Didn't know about that. kind of like the feature earlier we talked about where in leaf display we could pop up node id in bar chart, right?

Make all random calls reproducible

I wonder if we should simply remove those calls to seed() and then allow the user to specify a seat at the start of their notebook?

'function' object has no attribute 'model'

Hmm...must be an old version of dtreeviz?

Regression tree leaf purity

Are we capitalizing the absolute error label? Seems like we should leave it exactly as the library has it. I guess L1 vs L2 error is an ok purity. I'm...

Parser.setTrace(true) does not have the same semantics as with other targets

I think that shouldn't be trace but `ParserATNSimulator.trace_atn_sim = true;`

Parser.setTrace(true) does not have the same semantics as with other targets

trace is definitely for parser tracing.