Terence Parr

Results 526 comments of Terence Parr

I was just going to say that wildly different times could indicate an issue with garbage collection. I also noticed that the go target who is kind of walkie when...

zoiks!!! @jcking here's a good used case for testing and upgraded Go target.

Yeah, somebody needs to take a serious look at rebuilding the Go target. I might take a walk at it but it's lower on my priority list. sorry!

Thanks, @kaby76 for tracking this down! yeah, I was under impression Go target was kinda screwed up. Does anybody know Go well enough to fix this hash issue?

Hi @jimidle !! Yep, fork then cut new branch for a PR from dev branch (not master). Maybe we start by using @kaby76 awesome fix. Yep, multiple threads should be...

@mike-lischke I don't think fragment rules are visible to the parser. They are only meant as helper rules for other Lexer rules. I'm not sure what inlining would do but...

I'm not sure I can agree completely with this analysis. Once we have converted an ATN chunk to DFA for a given input sequence, we never do anymore LexerATNConfig for...

Hmm...pretty risky modifying the ATN construction...

Can you help me understand the prime motivation here? There's a lot to review and a lot of changes that could affect allow users, because it touches the tool itself.

I'm going to leave this active as it could be useful but I'm allocating my time to antlr-as-a-service proj at moment. thanks!