Terence Parr

Results 554 comments of Terence Parr

hi @kaby76 What's the warning you get? Seems like the tool not the target should give the warning maybe.

I can see adding a warning for this since we can detect it. I don't think we weren't about it now. Seems like there should be a syntax error or...

Improving ATN simulation trace: https://github.com/antlr/antlr4/pull/3957 More info. Looks like parent element *can* be null: ``` public class ArrayPredictionContext extends PredictionContext { /** Parent can be null only if full ctx...

Fixed by https://github.com/antlr/antlr4/pull/3958

Thanks @wukan1986 could you try cutting your data down? Also please upgrade to dtreeviz 2.0. thanks!

I wonder if this is an issue of a variety of different package versions on colab vs jupyter lab.

@tlapusan his version is lightgbm-3.3.3; mine is 3.2.1. Running his .py i get: ``` beast:~/Downloads/train $ python train.py Traceback (most recent call last): File "/Users/parrt/Downloads/train/train.py", line 57, in lgb.log_evaluation(10), AttributeError:...

I'm not familiar with the module stuff I'm afraid. can we be sure this won't break my simple java 8 world?

Hi. Thanks for the effort, but any change has to have a very good reason at this point in its life cycle. Is there a problem this is solving?