Terence Parr

Results 554 comments of Terence Parr

I will have to wait for @bjansen to have time to review this as I've been out of the loop for too long. Sorry!

hi! At this time I think I will hold off on auto completion and everything inside the grammar editor. Ace has a built-in mechanism for that which I will have...

hi. Sorry about that. I just I haven't been able to get back to this project! Glad that the tool itself is useful :)

hi @kaby76 thanks for the heads up. As usual an excellent analysis. The issue is that there are lots of different types that represent the same abstract concept of context....

hahah. it's ALWAYS the hash function. @marcospassos looks like there might be an issue. We need a map from X->X not a set so we can reuse the same instance.

I totally agree but my limited CSS skills have defeated me! haha. Would love some help here if you can figure out how to do that. It took me forever...

Is it related to this bug I added https://github.com/antlr/antlr4/issues/3845 ?

Yep, that sounds right. I gave up on trying to fix that bug when adding a print (cout) statement caused literally hundreds of lines of error messages to come out...

> if (lhs == nullptr && rhs == nullptr) dang. nope. says can't compare lhs (nonpointer type PredictionContext) to a nullptr. Somehow those refs have become null due to array...

Excellent point. Yeah I'm worried about that as well. Not sure how to handle that but perhaps we can simply detect when you were going to move away from the...