Terence Parr comments

Results 554 comments of


                                            Terence Parr

implement our own tree layout to avoid graphviz

The other approach is to use dot to compute the layout but generate our own SVG for the arrows (easy). To avoid graphviz trying to load svg (the problem we're...

Yes No labelling?

I don't believe we have any labels at this point.

dtreeviz fails with IndexError for n_classes >= 11

ah. yeah, sorry. I should put a check in there but only 10 classes can be handled right now. we had to handpick the colors. sorry about that.

dtreeviz fails with IndexError for n_classes >= 11

Nope :( sorry.

dtreeviz fails with IndexError for n_classes >= 11

thanks :) I'd be happy to accept a pull request that increased the number of color palettes ;)

dtreeviz fails with IndexError for n_classes >= 11

Yeah, That's the problem. I started running out of ideas for colors and default values above 10. May be a sequential color map is required.

dtreeviz fails with IndexError for n_classes >= 11

In principle, just add another list of colors so this works: ``` color_values = color_blind_friendly_colors[n_classes] ```

dtreeviz fails with IndexError for n_classes >= 11

See if you can set `dtreeviz.color_blind_friendly_colors[30+1] = [c]*30` for some color `c`.

Set incoming edge thicknesses proportional to the number of samples in that node

thanks and thanks :) Yep, relevant, but I'm not positive it'll actually look good. Should be an easy thing to code so not a huge waste if not used. just...

Support for tf df trees #181

hooray!!! The `tfdf` prefix looks very much like the common term `tfidf`... Perhaps we change that to simply prefix of `tf` everywhere?