dtreeviz icon indicating copy to clipboard operation
dtreeviz copied to clipboard

Support for tf df trees #181

Open tlapusan opened this issue 3 years ago • 4 comments

@parrt it contains the visualisations for Random Forest algo. The tensorflow DF contains more algorithms for decision forests and we can add them also in the future.

close #181

tlapusan avatar Aug 03 '22 07:08 tlapusan

hooray!!! The tfdf prefix looks very much like the common term tfidf... Perhaps we change that to simply prefix of tf everywhere?

parrt avatar Aug 05 '22 20:08 parrt

There are a couple of changes such as in interpretation.py that might affect other targets. Have you run through and checked the other kinds of trees and run tests?

parrt avatar Aug 05 '22 20:08 parrt

There are a couple of changes such as in interpretation.py that might affect other targets. Have you run through and checked the other kinds of trees and run tests?

yes, I spent some time for these changes and ran/tested all of them :)

tlapusan avatar Aug 08 '22 14:08 tlapusan

hooray!!! The tfdf prefix looks very much like the common term tfidf... Perhaps we change that to simply prefix of tf everywhere?

agree, I will rename them soon.

tlapusan avatar Aug 08 '22 14:08 tlapusan

Thanks, @tlapusan !

parrt avatar Aug 13 '22 22:08 parrt