Terence Parr
Terence Parr
Ok, looks like i've checked off all the items for release. Gotta check antlr4-tools but I'll start heading towards release.
Happy avoid the v tag; only added it before because the Go folks said they needed it. haha!! :)
@jimidle can I close this?
Nice work. I don't see anything scary in there other than we're moving some files around. Most of the code does look like just clean up. Happy if @ericvergnaud could...
Sounds like this is too big of a change for no outward improvement. I agree that refactoring PRs should be viewed skeptically. Sometimes it's worth it. The atn int vs...
I think @ericvergnaud's comment about risk-reward equation is valid though. Refactoring has a high risk and little reward in this case. Yes, it's much better to have "clean" code but...
A random unused rule can cause FOLLOW sets to be different if I recall. Yeah, this grammar is pretty messed up. The issue relates to whether or not lookahead "falls...
Ah. i think it's the LL(1) analyzer. See comments on `_LOOK()`. EOF can be added to FOLLOW set depending on hitting end of a rule. Not saying code is correct...
Hi guys...any change to the secret sauce parsing algorithm would require me to fully understand it again. Not sure I am willing to dig deep enough. Changing the grammar semantics...
I'd rather we focus on larger issues than grammar warnings that I might find too risky to merge. Maybe help with antlr4-lab?