Terence Parr

can you back out whitespace onlychanges so it's smaller to review?

So this is to support the goal of less code duplication across Target objects to convert antlr literals to target literals? On it's own, this looks ok (although big) but...

Thanks for the detailed explanation! I'm trying to learn go and just got my first go-based parser running yesterday. I will try to catch up over the next couple of...

All of the links from this page work for me. Can you be more specific about what links 404? https://www.antlr.org/api/

did you try to run mvn to get javadoc? We have to run a special process to generate those images. Somehow it's working to get the embed tag functional. Worried...

I am getting some errors from your PR: ``` ... /Users/parrt/antlr/code/antlr4/runtime/Java/src/org/antlr/v4/runtime/ParserInterpreter.java:72: error: bad use of '>' /** We need a map from (decision,inputIndex)->forced alt for computing ambiguous ^ /Users/parrt/antlr/code/antlr4/runtime/Java/src/org/antlr/v4/runtime/atn/PredictionContext.java:178: error:...

ping @dtonhofer

It appears that there are two NULL pointers coming in here: Line 24 in ArrayPredictionContext.h: ``` bool predictionContextEqual(const Ref &lhs, const Ref &rhs) { return *lhs == *rhs; } ```...

Well, I've simplified and am running into limits of my C++. ``` bool ArrayPredictionContext::equals(const PredictionContext &other) const { if (this == std::addressof(other)) { return true; } if (getContextType() != other.getContextType())...

My related PR is https://github.com/antlr/antlr4/pull/3863