friendly_id icon indicating copy to clipboard operation
friendly_id copied to clipboard

Don't call upstream if nothing found via friendly ID search

Open corwinstephen opened this issue 3 years ago • 4 comments

Prevent false positives when friendly ID doesn't match

corwinstephen avatar Jun 25 '21 15:06 corwinstephen

@corwinstephen thanks I added some suggestions; we can convert this from a guard clause to just use the result of exists_by_friendly_id? as that is what we're most interested in here.

parndt avatar Jun 29 '21 21:06 parndt

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 12 '21 22:10 stale[bot]

Hey sorry to disappear on this. What are you thinking here? Looks like the specs had some trouble getting started.

corwinstephen avatar Oct 13 '21 14:10 corwinstephen

@corwinstephen it looks to me like there are 16 test failures and they're probably related to us expecting friendly_id to call super

parndt avatar Oct 14 '21 07:10 parndt