Alex Panchenko

The test checks that connection obtained from the pooll second time can be used for query execution. Without this pool code change it returns the closed connection and query exection...

Since 4.13 the recommended way is using the `order` attribute of the `@Rule` annotation. It's described in the Ordering section in bottom of the javadoc. The sentence you linked is...

Surely it's possible to specify newer version of Hamcrest in project dependencies. The latest Hamcrest has more features, so if one uses it - obviously that would be the latest...

It seems like the only reason: TestRule can be created by.a method, so such a check covers both. Due to the way code is organized - class validation happens before...

It's possible to implement it differently, the question is if it's worth modifying old behaviour in a project which is not actively developed at the moment (kind of maintenance mode)....

it's slightly more involved, as exceptions should be thrown before or after that.

@marcphilipp that's exactly the purpose of the issue - currently JUnit 4 requires that the rule fields / methods should be declared with a type which extends `TestRule`.

Would be easier to implement if passing containers to the rule/extension constructor: ```java Network network = new Network(); GenericContainer container = new GenericContainer(...); @RegisterExtension TestcontainersExtension extension = new TestcontainersExtension(network, container);...

There are cases when identityHashCode is not needed, like `enum` or when it's already present in `toString()`, like default implementation in `Object`. It should not be added always for sure,...

It seems like the only breaking change is #1245