Tom Parker-Shemilt
Tom Parker-Shemilt
> I think removing it is fine, I never got around to making tests timeout to a per-test basis, sorry. No worries. I should probably have spotted/flagged issues with this...
https://github.com/palfrey/serial_test/pull/83 solves this by removing timeout_ms
Having just read [`wasm_bindgen_test`](https://github.com/rustwasm/wasm-bindgen/blob/main/crates/test-macro/src/lib.rs) I think a chunk of the problem is that it strips the `async` attribute from the test it spits out. Although [so does `tokio`](https://docs.rs/tokio-macros/0.2.0/src/tokio_macros/lib.rs.html#151-224) so I'm...
https://github.com/palfrey/serial_test/pull/82 should fix this. @cryptoquick Can you test that branch against your use case please?
I've merged https://github.com/palfrey/serial_test/pull/82 and so closing this. Please re-open if there's still an issue with your use case.
@opacam Any thoughts? I've just hit these again
FYI @gruns still seeing this one on https://github.com/gruns/icecream/commit/a90e838f63887dda02be842413890b504946a1e0. Any thoughts there?
[Blocked on Python 2.7 issues](https://github.com/gruns/icecream/issues/168)
Debatable. So, in terms of "does this change what gets installed or the actual behaviour of packages", I don't think so. AFAIK packages don't have access to what extras they...
> My 2c: This should certainly not be the default, pip-compile is doing the right thing by changing its default to `--strip-extras`. This ensures compatibility with constraints files, avoids pip...