Tom Parker-Shemilt

Results 216 comments of Tom Parker-Shemilt

@charliermarsh I'm seeing some test failures on Windows, and they appear to be related to path redactions in insta. There's some nice work for doing that cross-platform in `crates/uv/tests/common/mod.rs`, but...

> The difference is `# via -r pyproject.toml` vs. `# via uv_test (pyproject.toml)`. > > I don't know if you think we should match the output of `pip-compile`, but it...

@charliermarsh I've just updated to latest main. I'd regard this as done, except for the Windows test failures, which I'm not sure how to fix ([see previous comment on this](https://github.com/astral-sh/uv/pull/3269#issuecomment-2080143202))....

> If anyone else has bright ideas about how to fix the Windows issue, I'm all ears. `safe_filter_path` fixes the regex issues (mostly by copy/paste from `crates/uv/tests/common/mod.rs`) but there's still...

> I will own reviewing now. How's that going? I'm seeing a new fun set of conflicts, but didn't want to resolve those until the next bit of reviewing was...

> @palfrey - I made a few changes and left comments for each one to explain the motivation. This LGTM but I'll hold off on merging to give you time...

BTW, it doesn't seem to add sources for editables e.g. the `poetry_editable = { path = "../poetry_editable", editable = true }` in `tool_uv_sources` just comes out as `-e ../poetry_editable` with...

eb3ea9856ddfceb2f41c4f775a5e5d9bef6a1b5c fixes editables. I needed to change the `sources` key to `String` to cope with both package names and editables urls, which I'm a little uncertain about. Just going to...

Jinja2 says no changelog. See http://jinja.pocoo.org/docs/2.10/changelog/