Cohen3 icon indicating copy to clipboard operation
Cohen3 copied to clipboard

Fix mediadb str issues

Open palfrey opened this issue 3 years ago • 1 comments

There's an issue with the use of str in mediadb, and a lack of tests for it meant it didn't turn up, so I've fixed that.

palfrey avatar Feb 06 '22 21:02 palfrey

Codecov Report

Merging #44 (51db456) into master (25e6a85) will decrease coverage by 0.25%. The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
- Coverage   47.27%   47.02%   -0.25%     
==========================================
  Files          50       52       +2     
  Lines       10826    11408     +582     
==========================================
+ Hits         5118     5365     +247     
- Misses       5708     6043     +335     
Flag Coverage Δ
unittest 47.02% <63.63%> (-0.25%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
coherence/backends/fs_storage.py 43.26% <0.00%> (ø)
coherence/upnp/core/service.py 66.44% <0.00%> (ø)
coherence/upnp/devices/media_server.py 33.33% <ø> (ø)
coherence/base.py 58.23% <40.00%> (-0.44%) :arrow_down:
coherence/upnp/core/device.py 73.41% <66.66%> (-0.06%) :arrow_down:
coherence/backends/mediadb_storage.py 54.22% <100.00%> (ø)
coherence/upnp/devices/control_point.py 38.33% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39afd4...51db456. Read the comment docs.

codecov[bot] avatar Feb 19 '22 15:02 codecov[bot]

@opacam Any thoughts? I've just hit these again

palfrey avatar Jan 08 '23 19:01 palfrey

:rocket: Merged Thanks again @palfrey !!!! :smile:

opacam avatar Mar 11 '23 18:03 opacam