Phillip Alday
Phillip Alday
@likanzhan The reading of EDF files should be fine -- it should only be BDF that's impacted. If there has been a change in performance for EDF between EDF.jl v0.6...
I like this. Branching on type seems distinctly unjulian and we're still preserving the logical structure and data equivalence of the file, even if a round-tripped file won't be bit-for-bit...
The lack of check is actually an intentional design decision: https://github.com/beacon-biosignals/EDF.jl/blob/19e854977c3fc58bba3c5ec16a77d14ac2caed09/src/read.jl#L297 This way, we can support anything that `open` supports, which may or may not be traditional paths on a...
what about ```julia judge(Symbolics, BenchmarkConfig(;id="origin/HEAD", juliacmd=`julia -O3 -e'using Pkg; Pkg.update()'`); verbose=false) ``` ?
@schlichtanders maybe just at the top of https://github.com/JuliaInterop/RCall.jl/blob/master/test/basic.jl ?
What happens if you force a reinstall from within RCall? ```julia julia> using RCall julia> R"""install.packages("mvtnorm")""" ```
@schlichtanders there is an entry with the comment "callbacks" in the tests folder: https://github.com/JuliaInterop/RCall.jl/blob/master/test/basic.jl#L67 That seems like a good place to put it. :smile:
@ararslan thoughts on the behavior here? Essentially it transforms all non-standard evaluation in R (here: implicit conversion of a bare symbol into an expression whose value is that symbol) into...
@schlichtanders tests for this can go in https://github.com/JuliaInterop/RCall.jl/blob/master/test/convert/formula.jl. You can just use my examples from the discussion thread as tests. :smile: If you want to include the ggplot2 bit, then...
I'm not opposed to adding some tips to the docs in a section titled something like "Using RCall in CI". Two other places to look for examples: - [RCall's own...