Phillip Alday

Results 297 comments of Phillip Alday

@nalimilan you need `requires_one_based_indexing` for yours or change it to use `axes`. I like the idea of defining a `formula` stub here. Then downstream packages can do things like define...

`statistic` feels like it’s asking for a name collision and `teststatistic` is long and awkward. My ranking: `teststat` > `statistic` >> `teststatistic`

After a little bit of thinking, `statistic` actually sounds nice because it could also be used in other, non-testing contexts.

Without having looked at your fork -- you can write code that works with Py2+3 simultaneously with `six` and a few other tricks. If you do this, we can integrate...

Regarding (1): I have no strong preference for how to make it compatible with both simultaneous. Py2.7 + Py3 with just a few `try` blocks or the like is perfectly...

Because it's already Python 2.7 code, so it's trivial in terms of effort, and for better or worse, Python 2.7 is still around in a lot of places.

Thanks for putting in so much effort. This is multiple pull requests. If you separate out the addition of the doc strings (for existing functions, *not for new ones*) into...

The docstrings are a separate issue from the other things and really should be a separate pull request. That will allow us to review/comment on the docstrings as a purely...

@DimitriPapadopoulos As pointed out in the README, there is a Python 3 version available: https://github.com/bids-standard/pyedf/blob/d39966f7b80444dce6e2ecfaf1bfcd8b7225a824/README.md?plain=1#L5 Notably, that work began before Python 2 support EOL. But as to why not make...

Have you tried the `close()` method? To help any more, I'll need to see more of your code.