Jon Pascoe
Jon Pascoe
Here's a new one: https://join.slack.com/t/icecube-corp/shared_invite/zt-118ro0kvr-AKGf14JskPuLa07fLEFaJA
@thibaudclement / @vl3 - I've updated the link, should work now
Yep, it's a known issue. If you switch to `github.io` then they'll work. > homepage: https://seejohnrun.github.io/ice_cube > > and quick introduction: https://seejohnrun.github.io/ice_cube/static/ice_cube_ruby_nyc.pdf This issue will be redundant shortly, as we're...
They'll be fixed in the next release.
Hey @epologee, thanks for sending this through! I'll find some time in the next day or two to review this properly. In the mean time, can you add a changelog...
I think once you get your first PR through, you don't need approval for future PR test runs.
Can you resolve the failing tests? I'll then do a full review and merge it 👍🏻 Although ... these might be tests that I've broken by reverting another branch 🤔...
@seejohnrun - using `.occurrences` as per the new test added [here](https://github.com/ice-cube-ruby/ice_cube/pull/523/files#diff-a2d3993d84af8f47303f4214174ddfc13cfe4fb4af129af32d04bf55a97fdf45R365), you can see that the schedule is adding the correct first occurrence. Do you have any insight into why...
This looks good to me @seejohnrun
@nehresma / @mattbooks / @ovinix - If you can get this PR cleaned up and resolve the feedback and conflicts with `master`, I'll give it a proper review.