Jon Pascoe

Results 36 comments of Jon Pascoe

OK - having had a poke about, we cannot remove the `date.day_names` etc from the translation files. These are used by the localisation calls (`I18n.l`) [such as here](https://github.com/ice-cube-ruby/ice_cube/blob/master/lib/ice_cube/validations/until.rb#L37). Please revert...

Was fixed in #553 and will be updated on RubyGems site once a new release is deployed

I'll take a look. Am going to try to dedicate sometime this holiday season to get things tidied up and in better shape.

Thanks for the review @jkehres. Can we get the tests running/passing?

@jorgemanrubia - Since nothing has moved on this PR for a long time ... it might be easiest if you can fork it, get the tests passing and then we...

The problem is that there is no protection against rules which don't result in any occurrences within a schedule. PR #554 will add validations to catch most cases, but I...

Sync doesn't work with the official Obsidian sync service. I expect because you're storing the data in the `.obsidian` directory, which isn't fully synced?

Hi @larskuhnt, Thank you for your contribution ... this looks great! Just a couple of comments, but otherwise looks spot on. 👍🏻

Don't worry about fixing the linting issues ... that is resolved on #552 which I'll merge first. I'm just waiting on @seejohnrun updating my access so I can actually fix...

@larskuhnt - could you please pull `master` and see whether this fixes all of the tests?